jr at jriddell.org
Thu Mar 6 06:04:12 UTC 2003
On Thu, 6 Mar 2003, Michel Hermier wrote:
> Just one quick thought. Looking at the code I found only one assert(according
> to a konqueror search) in phpwriter. Why you don't use them more ofen. I
> found places(at least one that I surely know, and submitted one patch before
> related to the bug 53371) where the returned pointer is not checked to be
> null or not, and pointers that are never expected to be null not checked.
> I'm sure this could help to clarify some bugs (now or in the future).
assert() causes the programme to crash and, on the whole, we want to avoid
crashing. The assert() in phpwriter should be removed, we certainly don't
want to crash the program just because the user has done multiple
Far better to call kdWarning() and recover without a crash. There are
certainly places where this should be done but isn't.
More information about the umbrello-devel