mp4 in 12.0

[Yannis Calotychos]

hi Urs

thank you for your response.
Changing  "CONTENTGROUP” to "WORK" for the "TIT1” frame would work too!

have a good weekend,
yannis


> On 12 Mar 2022, at 9:30 AM, Urs Fleisch <urs.fleisch at gmail.com> wrote:
> 
> Hi Yannis,
> 
> Thanks for your suggestion. We have exactly one case for
> "CONTENTGROUP" (ID3v2 frame "TIT1") and one case for "WORK" (MP4 atom
> "\251wrk"). I personally would rather change the "CONTENTGROUP" to
> "WORK" for the "TIT1" frame
> 
> ```
> std::make_pair("TIT1", "WORK"), // 'Work' in iTunes
> ```
> 
> although the official name for "TIT1" is 'Content group description'
> frame. But with iTunes, the name "Work" is probably more widely used
> than "Content group description". Any other opinion?
> 
> I agree that we should add `{ "TCMP", "COMPILATION" }`.
> 
> Best regards,
> Urs
> 
> On Wed, Mar 9, 2022 at 6:39 AM Yannis Calotychos <ycalot at gmail.com> wrote:
>> 
>> Hello,
>> 
>> -----------------------------
>> mp4tag.cpp
>> -----------------------------
>> In 12.0 you have added support for
>>    { "\251wrk", "WORK" },
>> 
>> However the field WORK is equivalent to what you decode in other formats as CONTENTGROUP (eg mp3/mpeg)
>> Is there any chance you could change this to
>>    { "\251wrk", "CONTENTGROUP" },
>> 
>> -----------------------------
>> id3v2frame.cpp
>> -----------------------------
>> Also, since we are at it, you could add :
>>  { "TCMP", "COMPILATION" },
>> 
>> in id3v2frame.cpp for parity with other formats.
>> it is currently missing.
>> 
>> 
>> 
>> 
>> let me know if you need more info.
>> 
>> thanks
>> yannis calotychos