Re: Add functions to TagLib.

[신병준]

Hello Birunthan. 


I am sorry,  I don't intent to steal your code, 
I don't know how to mix  with wheeler's code and your code. 
and I just need to convert C functions from your code. 


Please check to attached files. 
I  separated your code and wheeler's code. 


I hope that your effort helps C language programmers.


If I have to change anything, Please let me know. 


Thanks!
 Bolero.








-----Original Message-----
From: "Birunthan Mohanathas"<birunthan.mohanathas at gmail.com> 
To: "신병준"<mbyn33 at naver.com>; <taglib-devel at kde.org>; 
Cc: 
Sent: 2012-07-23 (월) 17:36:26
Subject: Re: Add functions to TagLib.

Some notes:

- Your Extract*() functions are direct copies of my Extract*() functions in Cover.cpp
- Your taglib_save_thumbnail() function is a copy of my GetEmbedded() function (Cover.cpp#L67) with a few added/changed lines

- Your WriteCover() function is a copy of my WriteCover() function (Cover.cpp#L248)

In addition, "your" code has the same comments and uses my coding style 
instead of the TagLib/KDE style (e.g. "type* name" instead of "type 
*name", tab indentation instead of 2 space indentation, "if ()" instead 
of "if()").

While it is possible that you may have come up with some of the shorter functions on your own, the evidence above suggests otherwise. I don't mind people using my code as long as they either do so under the terms of the GNU GPL v2 license or (simply) credit me. Stealing code and claiming that you've done the work is not cool.




On Mon, Jul 23, 2012 at 8:52 AM, 신병준 <mbyn33 at naver.com> wrote:


Hello, 


I added new function at TagLib. 


This function can get album art from music files with C language. 


Please add this code to your project  bindings folder. 




Thanks
Bolero.
                                             
_______________________________________________

taglib-devel mailing list

taglib-devel at kde.org

https://mail.kde.org/mailman/listinfo/taglib-devel






-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/taglib-devel/attachments/20120723/b206fd6c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bindings.zip
Type: application/x-zip-compressed
Size: 9644 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/taglib-devel/attachments/20120723/b206fd6c/attachment-0001.bin>