TagLib in XBMC

[Geoffrey McRae]

If you had of read on I stated

> If I was to patch this functionality into TagLib would you welcome a
> patch? Keeping backwards compatibility of-course so as to not break
> existing applications.

Perhaps I did not word what I was trying to say properly, what I ment to
say was that it is poor design for us to include your library into XBMC
with custom patches, when there is a shared system library available
that should be used instead of bloating the application.

It is not reasonable for me to assume TagLib ever had it, but it is
reasonable to assume that it should as it is common practice in agnostic
code, especially shared libraries.

I am offering to write a patch to implement this and submit it upstream
to have it added, I am asking if it would be accepted?

-Geoff

On Sat, 2011-01-29 at 12:31 -0500, Jeff Mitchell wrote:
> On 01/27/2011 06:11 PM, Geoffrey McRae wrote:
> > It currently is static linked at the moment, but we don't want to, nor
> > should we have to maintain patches to implement this functionality.
> 
> Not to be contrary, but if you want a feature in a library that isn't
> currently a part of that library, saying that "we shouldn't have to
> maintain patches to implement this functionality" is totally bogus. Of
> course you should. TagLib never advertised this feature, so it's not
> reasonable for you to expect that it has it.
> 
> If you write the functionality you need and don't want to maintain your
> own patches, contribute it upstream.
> 
> --Jeff