ID3 chunks in WAVE/AIFF files

[Stephen F. Booth]

On Fri, Oct 29, 2010 at 10:03 AM, Stephen F. Booth <me at sbooth.org> wrote:

> 2010/10/29 Lukáš Lalinský <lalinsky at gmail.com>
>
> I'm not sure if this is the best solution. It will read the tag from
>> 'id3 ', but then write a duplicate 'ID3 '. We should either
>> consistently use the original chunk ID, or remove existing 'id3 '.
>>
>
> You're right- I realized this after I sent the patch and took a look at the
> save() code.  Having both an 'ID3 ' chunk and an 'id3 ' chunk would be bad.
>
> I'm not aware of a standard for the chunk id, so I think the best thing to
> do in this case is to preserve the original one.  But standardization is
> also a good argument so I'm on the fence.
>

I've attached a patch that will keep the existing name of the ID3 chunk.

Stephen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/taglib-devel/attachments/20101029/c54ffdaf/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id3.patch
Type: application/octet-stream
Size: 2264 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/taglib-devel/attachments/20101029/c54ffdaf/attachment.dll