Wrong (?) bitrate for wav files

[Nicolas Wack]

Hi,

This is mostly nit-picking at this point, and I get as confused as everyone 
with the kilo/kibibyte thing, but for coherency's sake I think there is a bug 
in the way TagLib returns the bitrate for for wav files:

a stereo wav file will have a bitrate of 1378 instead of 1411, because TagLib 
takes the number of bits (1,411,200) and returns that divided by 1024 (see 
taglib/riff/wav/wavproperties.cpp:99)

However,  AFAIK the other formats in TagLib (ie, mp3, mp4, etc...) return the 
number of bits/s divided by 1000, to have a result in kilobit/s instead of 
kibibit/s.

It also seems the "standard" unit for audio bitrates is the kilo (1000) 
instead of the kibi (1024), see for instance:
http://en.wikipedia.org/wiki/Data_rate_units#Examples

So I would propose that wavproperties.cpp be changed to behave the same way as 
the other tag types.

Thanks,

Nico.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/taglib-devel/attachments/20100407/86e359d2/attachment.sig