Cannot build MP4/ASF libraries

[Christopher Boumenot]

Greetings,

I am attempting to build the taglib library with support for MP4/ASF
and failing miserably.  I am running Ubuntu v8.10.  I believe that I
have narrowed the breakage down to this revision.

------------------------------------------------------------------------
r883891 | mitchell | 2008-11-13 14:23:56 -0500 (Thu, 13 Nov 2008) | 5 lines

config.h doesn't exist, at least in my checkout, so explicitly
defining HAVE_CONFIG_H was breaking build.  I'm guessing this was a
mistake, and should either be taken out, or something needs to be
fixed.

Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt      (revision 883890)
+++ CMakeLists.txt      (revision 883891)
@@ -7,7 +7,7 @@
 OPTION(WITH_ASF "Enable ASF tag reading/writing code"  OFF)
 OPTION(WITH_MP4 "Enable MP4 tag reading/writing code"  OFF)

-add_definitions(-DHAVE_CONFIG_H)
+#add_definitions(-DHAVE_CONFIG_H)

 #add some KDE specific stuff
 set(LIB_SUFFIX "" CACHE STRING "Define suffix of directory name (32/64)" )

To reproduce:

(Ensure CPPUNIT is installed.)

  $ cmake .
  $ make edit_cache
  (enable WITH_ASF, and WITH_MP4)
  $ make check

The build will fail while compiling the unit tests.  If you do not
have CPPUNIT installed the build will succeed, but if you inspect .so
file, you will see that there is no mention of ASF or MP4.

The person is correct that config.h does not exist, it is generated as
a result of running "cmake ." in the taglib directory.

To fix:

Revert checkin 883891.


I can file a bug as well if that is more appropriate.


Christopher