[PATH] TagLib compiled using Visual C++ 2003 (msvc71)

[Tanguy Krotoff]

Hello

Here a small patch against latest TagLib svn (kdesupport).
It allows to compile TagLib using Visual C++ 2003 (msvc71)

taglib/CMakeLists.txt line 30:

  if (MSVC_VERSION GREATER 1399)
    # If using Visual C++ 2005 (MSVC80) and greater (MSVC_VERSION=1400)
    add_definitions(/D_CRT_SECURE_NO_DEPRECATE
/D_CRT_NONSTDC_NO_DEPRECATE /Zc:wchar_t-)
  endif (MSVC_VERSION GREATER 1399)

Explanations:
/Zc:wchar_t is recognized by msvc71, /Zc:wchar_t- is not (the - is
very important and was introduced only with msvc >= msvc80)
Thus /Zc:wchar_t- is recognized as /Zc:wchar_t and this is not what we want :)
Default behavior of msvc71 is already /Zc:wchar_t-

Solution:
Test the msvc version and add the compiler flag only if compiler >=
msvc80 (e.g MSVC_VERSION >= 1400)
Same for /D_CRT_SECURE_NO_DEPRECATE and /D_CRT_NONSTDC_NO_DEPRECATE,
there were introduced with msvc >= msvc80

I can apply myself the patch if needed via my KDE account tkrotoff

-- 
Tanguy Krotoff <tkrotoff at gmail.com>
+33 6 68 42 70 24
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msvc71.diff
Type: application/octet-stream
Size: 640 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/taglib-devel/attachments/20090422/90ea55d9/attachment.dll