kdesupport/taglib/ogg

Scott Wheeler wheeler at kde.org
Sat Sep 16 14:11:47 CEST 2006


SVN commit 585155 by wheeler:

Invalid iterators are ungood.  Mmmkay?

CCMAIL:taglib-devel at kde.org


 M  +4 -2      xiphcomment.cpp  


--- trunk/kdesupport/taglib/ogg/xiphcomment.cpp #585154:585155
@@ -196,9 +196,11 @@
 {
   if(!value.isNull()) {
     StringList::Iterator it = d->fieldListMap[key].begin();
-    for(; it != d->fieldListMap[key].end(); ++it) {
+    while(it != d->fieldListMap[key].end()) {
       if(value == *it)
-        d->fieldListMap[key].erase(it);
+        it = d->fieldListMap[key].erase(it);
+      else
+        it++;
     }
   }
   else


More information about the taglib-devel mailing list