Dirty pointer in TagLib::FLAC::FilePrivate::tag might lead to crash if no FLAC tags are read
Allan Sandfeld Jensen
kde at carewolf.com
Sun May 14 21:16:59 CEST 2006
On Saturday 13 May 2006 22:31, Bjoern Petersen wrote:
> 2006/5/13, Diego 'Flameeyes' Pettenò <flameeyes at gentoo.org>:
> > The subject pretty much summaries the problem :)
> > The tag member of TagLib::FLAC::FilePrivate is not initialised, so it
> > might lead to crashes when no tags are read from a FLAC file, as its
> > de-referencing will point to nobody knows what (but doesn't return NULL).
> It also seems as if the tag pointer, is not deleted in
> TagLib::FLAC::~FilePrivate() (flacfile.cpp at line 61). Or have I
> missed something?
tag is pointing to one of the three possible tags ID3v1, ID3v2 or XiphComment.
deleting it would delete one of them twice.
I am fixing the initialization right away.
More information about the taglib-devel