[education/rkward/kf5] /: Fix crash when manually adding pluginmaps

Thomas Friedrichsmeier null at kde.org
Sat Sep 7 08:30:09 BST 2024


Git commit 36787a323b6b2a7a51ded370bb6fda5d66d5fcc9 by Thomas Friedrichsmeier.
Committed on 07/09/2024 at 07:29.
Pushed by tfry into branch 'kf5'.

Fix crash when manually adding pluginmaps

CCBUG: 492731

M  +1    -0    ChangeLog
M  +1    -1    rkward/settings/rksettingsmoduleplugins.cpp

https://invent.kde.org/education/rkward/-/commit/36787a323b6b2a7a51ded370bb6fda5d66d5fcc9

diff --git a/ChangeLog b/ChangeLog
index b3f878154..2916138d3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,4 @@
+- Fixed: Crash when manually adding plugin maps via "Manage R packages and pluigns"
 - Fixed: Better support for running from non-standard paths on Linux (e.g. user-local installation in home dir)
 - Fixed: Added REUSE license information where missing
 - Fixed: Handling of carriage returns in R Console window (used in progress bars, importantly)
diff --git a/rkward/settings/rksettingsmoduleplugins.cpp b/rkward/settings/rksettingsmoduleplugins.cpp
index c4b95e155..4f9b38cfb 100644
--- a/rkward/settings/rksettingsmoduleplugins.cpp
+++ b/rkward/settings/rksettingsmoduleplugins.cpp
@@ -562,7 +562,7 @@ void RKSettingsModulePluginsModel::insertNewStrings (int above_row) {
 			plugin_maps.ordered_ids.insert(above_row, inf.id);
 		}
 	}
-	endInsertRows ();
+	endResetModel();
 }
 
 void RKSettingsModulePluginsModel::swapRows (int rowa, int rowb) {


More information about the rkward-tracker mailing list