[education/rkward] /: Fix crash when manually adding pluginmaps

Thomas Friedrichsmeier null at kde.org
Sat Sep 7 08:27:56 BST 2024


Git commit 1a2d253c5f9a30c3294f8bc300753e60b18b91ed by Thomas Friedrichsmeier.
Committed on 07/09/2024 at 07:27.
Pushed by tfry into branch 'master'.

Fix crash when manually adding pluginmaps

BUG: 492731

M  +1    -0    ChangeLog
M  +1    -1    rkward/settings/rksettingsmoduleplugins.cpp

https://invent.kde.org/education/rkward/-/commit/1a2d253c5f9a30c3294f8bc300753e60b18b91ed

diff --git a/ChangeLog b/ChangeLog
index 49d8ef1c9..fabda024b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,5 @@
 --- Version 0.8.1 - UNRELEASED
+- Fixed: Crash when manually adding plugin maps via "Manage R packages and pluigns"
 - Fixed: Abnormal exit on Windows while trying to launch gpgpme (triggered from PDF previews)
 - Fixed: Failure to paint symbols in onscreen device, under some circumstances
 - Fixed: Potential library conflicts on systems shipping a more recent version of libglib2 than included in the AppImage
diff --git a/rkward/settings/rksettingsmoduleplugins.cpp b/rkward/settings/rksettingsmoduleplugins.cpp
index 5c3022fd7..9e46c7bad 100644
--- a/rkward/settings/rksettingsmoduleplugins.cpp
+++ b/rkward/settings/rksettingsmoduleplugins.cpp
@@ -563,7 +563,7 @@ void RKSettingsModulePluginsModel::insertNewStrings (int above_row) {
 			plugin_maps.ordered_ids.insert(above_row, inf.id);
 		}
 	}
-	endInsertRows ();
+	endResetModel();
 }
 
 void RKSettingsModulePluginsModel::swapRows (int rowa, int rowb) {


More information about the rkward-tracker mailing list