[education/rkward] rkward/plugin: This will hopefully make url formatting problems accessible to the auto-tests

Thomas Friedrichsmeier null at kde.org
Thu Jun 16 12:56:03 BST 2022


Git commit 69827f7857976737ad196c73bfd7410ea22a9e99 by Thomas Friedrichsmeier.
Committed on 16/06/2022 at 11:55.
Pushed by tfry into branch 'master'.

This will hopefully make url formatting problems accessible to the auto-tests

M  +1    -1    rkward/plugin/rkpluginbrowser.cpp

https://invent.kde.org/education/rkward/commit/69827f7857976737ad196c73bfd7410ea22a9e99

diff --git a/rkward/plugin/rkpluginbrowser.cpp b/rkward/plugin/rkpluginbrowser.cpp
index f16d5bec..30814576 100644
--- a/rkward/plugin/rkpluginbrowser.cpp
+++ b/rkward/plugin/rkpluginbrowser.cpp
@@ -92,7 +92,7 @@ void RKPluginBrowser::textChanged (RKComponentPropertyBase *) {
 	QUrl url = QUrl::fromUserInput (selection->value ().toString (), QDir::currentPath (), QUrl::AssumeLocalFile);
 	if (!url.isValid ()) url = QUrl (selector->getLocation ());
 	QString urlstring = only_local ? url.url (QUrl::PreferLocalFile) : url.url ();
-	if (url.url () != selection->value ().toString ()) {
+	if (urlstring != selection->value ().toString ()) {
 		// NOTE: We refuse to accept relative urls
 		selection->setValue (urlstring);
 	}


More information about the rkward-tracker mailing list