[education/rkward] /: Several import functions do not (any longer?) support urls as file specification.

[Thomas Friedrichsmeier]

Git commit 009de5c18ae898f8daa0d4bacd194a28a60dfcd5 by Thomas Friedrichsmeier.
Committed on 16/06/2022 at 11:53.
Pushed by tfry into branch 'master'.

Several import functions do not (any longer?) support urls as file specification.

M  +1    -0    ChangeLog
M  +1    -1    rkward/plugins/00saveload/import/import_stata.xml
M  +1    -1    rkward/plugins/00saveload/import/import_xls.xml
M  +1    -1    rkward/plugins/00saveload/import/import_xls_xlconnect.xml

https://invent.kde.org/education/rkward/commit/009de5c18ae898f8daa0d4bacd194a28a60dfcd5

diff --git a/ChangeLog b/ChangeLog
index 92296dac..d57615eb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,4 @@
+- Fixed: Excel import plugin failed to accept file name
 - Add option to offer code completion/hinting in all file types not just R scripts (e.g. in .Rmd files)
 - Fix zooming help/output pages with Ctrl+scroll wheel, when compiled with QWebEngine
 - Fix problem handling rkward:// links from dialogs on some sytems
diff --git a/rkward/plugins/00saveload/import/import_stata.xml b/rkward/plugins/00saveload/import/import_stata.xml
index 6ed11060..90094626 100644
--- a/rkward/plugins/00saveload/import/import_stata.xml
+++ b/rkward/plugins/00saveload/import/import_stata.xml
@@ -13,7 +13,7 @@
 	<dialog label="Import STATA file">
 		<tabbook>
 			<tab id="tab_general" label="General">
-				<browser type="file" allow_urls="true" id="file" label="File name" filter="*.dta" />
+				<browser type="file" allow_urls="false" id="file" label="File name" filter="*.dta" />
 				<stretch/>
 				<row>
 					<saveobject id="saveto" initial="my.stata.data" label="Object to save to"/>
diff --git a/rkward/plugins/00saveload/import/import_xls.xml b/rkward/plugins/00saveload/import/import_xls.xml
index d0660d8b..f8edde91 100644
--- a/rkward/plugins/00saveload/import/import_xls.xml
+++ b/rkward/plugins/00saveload/import/import_xls.xml
@@ -10,7 +10,7 @@
 	<dialog label="Import Microsoft EXCEL sheet">
 		<tabbook>
 			<tab id="tab_general" label="General">
-				<browser type="file" allow_urls="true" id="file" filter="*.xls *.xlsx" label="File name" />
+				<browser type="file" allow_urls="false" id="file" filter="*.xls *.xlsx" label="File name"/>
 				<input label="Name or number of sheet" id="sheetname" initial="1" size="medium" />
 				<frame>
 					<checkbox id="header" value="TRUE" value_unchecked="FALSE" label="Use first row as column names" checked="true"/>
diff --git a/rkward/plugins/00saveload/import/import_xls_xlconnect.xml b/rkward/plugins/00saveload/import/import_xls_xlconnect.xml
index a5c84c22..517a231c 100644
--- a/rkward/plugins/00saveload/import/import_xls_xlconnect.xml
+++ b/rkward/plugins/00saveload/import/import_xls_xlconnect.xml
@@ -13,7 +13,7 @@
 	<dialog label="Import Microsoft EXCEL sheet">
 		<tabbook>
 			<tab id="tab_general" label="General">
-				<browser type="file" id="file" filter="*.xls *.xlsx" label="File name" />
+				<browser type="file" id="file" filter="*.xls *.xlsx" label="File name" allow_urls="false" />
 				<input label="Index or "name" of sheet" id="sheet" initial="1" size="small" />
 				<frame>
 					<checkbox id="header" checked="true" label="Use first row as column names"/>