[rkward-cvs] SF.net SVN: rkward: [2137] branches/KDE4_port

[tfry at users.sourceforge.net]

Revision: 2137
          http://rkward.svn.sourceforge.net/rkward/?rev=2137&view=rev
Author:   tfry
Date:     2007-10-28 11:17:36 -0700 (Sun, 28 Oct 2007)

Log Message:
-----------
Undo hiding of code completion window on focus out. The reason for focus out may be a click in the completion popup itself.

Modified Paths:
--------------
    branches/KDE4_port/TODO_KDE4
    branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp
    branches/KDE4_port/rkward/windows/rkcommandeditorwindow.h

Modified: branches/KDE4_port/TODO_KDE4
===================================================================
--- branches/KDE4_port/TODO_KDE4	2007-10-28 18:03:33 UTC (rev 2136)
+++ branches/KDE4_port/TODO_KDE4	2007-10-28 18:17:36 UTC (rev 2137)
@@ -32,9 +32,8 @@
 rkcommandeditorwindow
 	- code completion
 		- probably we can trim down the completion widget by providing custom headerData()? (Low priority)
-		-* completion pop up vanishes on any mouse click - can neither select any completion nor resize the popup
-			-* the "Setup" button on the pop up works though
 		-* Code completion setup wizard could (looks better that way?) be in either tab or page format
+			- Can't do any thing about this. It part of the katepart.
 	- placement of menu options?
 
 rkward
@@ -85,6 +84,7 @@
 	   takes you to the "R-Backend" tab on the Settings dialog. Instead it should go 
 	   to the "R-Packages" tab.
 		+ Fixed, but both "Plugins" and "R-Pacakges" text on the left panel remain selected
+			- likely bug in KDE libs
 
 data editor:
 	- definitely needs better porting

Modified: branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp
===================================================================
--- branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp	2007-10-28 18:03:33 UTC (rev 2136)
+++ branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp	2007-10-28 18:17:36 UTC (rev 2137)
@@ -124,18 +124,6 @@
 	setPopupMenu ();
 }
 
-void RKCommandEditorWindow::focusOut (KTextEditor::View* v) {
-	RK_TRACE (COMMANDEDITOR);
-	RK_ASSERT (v == m_view);
-
-	KTextEditor::CodeCompletionInterface *iface = qobject_cast<KTextEditor::CodeCompletionInterface*> (m_view);
-	if (!iface) {
-		RK_ASSERT (false);
-		return;
-	}
-	iface->abortCompletion ();
-}
-
 void RKCommandEditorWindow::setPopupMenu () {
 	RK_TRACE (COMMANDEDITOR);
 

Modified: branches/KDE4_port/rkward/windows/rkcommandeditorwindow.h
===================================================================
--- branches/KDE4_port/rkward/windows/rkcommandeditorwindow.h	2007-10-28 18:03:33 UTC (rev 2136)
+++ branches/KDE4_port/rkward/windows/rkcommandeditorwindow.h	2007-10-28 18:17:36 UTC (rev 2137)
@@ -139,7 +139,6 @@
 	void tryCompletion ();
 	void setPopupMenu ();
 	void focusIn (KTextEditor::View *);
-	void focusOut (KTextEditor::View *);
 /** Show help about the current word. */
 	void showHelp ();
 /** run the currently selected command(s) */


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.