[rkward-cvs] SF.net SVN: rkward: [2136] branches/KDE4_port/rkward/windows/ rkcommandeditorwindow.cpp

[tfry at users.sourceforge.net]

Revision: 2136
          http://rkward.svn.sourceforge.net/rkward/?rev=2136&view=rev
Author:   tfry
Date:     2007-10-28 11:03:33 -0700 (Sun, 28 Oct 2007)

Log Message:
-----------
Fix string underrun in argument hinting

Modified Paths:
--------------
    branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp

Modified: branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp
===================================================================
--- branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp	2007-10-28 17:50:03 UTC (rev 2135)
+++ branches/KDE4_port/rkward/windows/rkcommandeditorwindow.cpp	2007-10-28 18:03:33 UTC (rev 2136)
@@ -439,10 +439,10 @@
 	// now find where the symbol to the left ends
 	// there cannot be a line-break between the opening brace, and the symbol name (or can there?), so no need to fetch further context
 	int potential_symbol_end = matching_left_brace_pos - 1;
-	while ((potential_symbol_end > 0) && current_context.at (potential_symbol_end).isSpace ()) {
+	while ((potential_symbol_end >= 0) && current_context.at (potential_symbol_end).isSpace ()) {
 		--potential_symbol_end;
 	}
-	if (current_context.at (potential_symbol_end).isSpace ()) {
+	if (potential_symbol_end < 0) {
 		hideArgHint ();
 		return;
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.