[rkward-cvs] SF.net SVN: rkward: [1384] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 1384
          http://svn.sourceforge.net/rkward/?rev=1384&view=rev
Author:   tfry
Date:     2007-02-12 08:48:19 -0800 (Mon, 12 Feb 2007)

Log Message:
-----------
Some more details on changing var types

Modified Paths:
--------------
    trunk/rkward/TODO
    trunk/rkward/rkward/core/rkvariable.cpp

Modified: trunk/rkward/TODO
===================================================================
--- trunk/rkward/TODO	2007-02-12 16:47:36 UTC (rev 1383)
+++ trunk/rkward/TODO	2007-02-12 16:48:19 UTC (rev 1384)
@@ -21,6 +21,9 @@
 			- seems to happen more often with larger data frames
 			- more precisely: seems to happen after scrolling
 			- no idea, why this happens
+		- converting objects to a different type is broken (works in the editor, but the type remains unchanged in the backend)
+			- maybe we could do the change in the backend, and then sync
+				- function rk.change.vector.mode() to change the mode, keeping attributed, and adding invalid values where needed
 
 Compilation / technical
 	- Incorporate FreeBSD patches http://www.freshports.org/math/rkward/files.php?message_id=200609172111.k8HLBiob081349@repoman.freebsd.org

Modified: trunk/rkward/rkward/core/rkvariable.cpp
===================================================================
--- trunk/rkward/rkward/core/rkvariable.cpp	2007-02-12 16:47:36 UTC (rev 1383)
+++ trunk/rkward/rkward/core/rkvariable.cpp	2007-02-12 16:48:19 UTC (rev 1384)
@@ -56,7 +56,6 @@
 	// if the variable is currently opened for editing, all values need to be rechecked / resynced
 	if (myData ()) {
 		bool internal_sync = myData ()->immediate_sync;
-		setSyncing (false);
 		// quick and dirty approach! TODO: make more efficient
 		QStringList list;
 		for (int i=0; i < getLength (); ++i) {
@@ -72,6 +71,7 @@
 		setDataType (new_type);
 		allocateEditData (editor);
 
+		setSyncing (false);
 		int i = 0;
 		for (QStringList::const_iterator it = list.constBegin (); it != list.constEnd (); ++it) {
 			setText (i, *it);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.