[rkward-cvs] SF.net SVN: rkward: [1009] trunk/rkward

[tfry at users.sourceforge.net]

Revision: 1009
          http://svn.sourceforge.net/rkward/?rev=1009&view=rev
Author:   tfry
Date:     2006-12-15 06:15:25 -0800 (Fri, 15 Dec 2006)

Log Message:
-----------
Slightly better heuristics for determining the line step of integer spinboxes

Modified Paths:
--------------
    trunk/rkward/ChangeLog
    trunk/rkward/rkward/misc/rkspinbox.cpp
    trunk/rkward/rkward/plugin/rkpluginspinbox.cpp
    trunk/rkward/rkward/plugins/00saveload/load/source/description.xml

Modified: trunk/rkward/ChangeLog
===================================================================
--- trunk/rkward/ChangeLog	2006-12-13 17:38:16 UTC (rev 1008)
+++ trunk/rkward/ChangeLog	2006-12-15 14:15:25 UTC (rev 1009)
@@ -1,3 +1,4 @@
+- fixed: integer spinboxes with starting values greater than 1 would get unreasonable change steps
 - fix compilation with some versions of KDE / GCC
 - small improvements to syntax highlighting definition
 - in console, make cursor go to empty next line after pressing enter, before there is output (more like in the real console)

Modified: trunk/rkward/rkward/misc/rkspinbox.cpp
===================================================================
--- trunk/rkward/rkward/misc/rkspinbox.cpp	2006-12-13 17:38:16 UTC (rev 1008)
+++ trunk/rkward/rkward/misc/rkspinbox.cpp	2006-12-15 14:15:25 UTC (rev 1009)
@@ -86,6 +86,10 @@
 	QValidator *new_validator = new QIntValidator (min, max, this);
 
 	int range_power = (int) (log10 (max - min));
+	int range_power_limit = (int) (log10 (initial)) + 2;
+	if (range_power > range_power_limit) {
+		range_power = range_power_limit;
+	}
 	if (range_power <= 0) {
 		range_power = 1;
 	}

Modified: trunk/rkward/rkward/plugin/rkpluginspinbox.cpp
===================================================================
--- trunk/rkward/rkward/plugin/rkpluginspinbox.cpp	2006-12-13 17:38:16 UTC (rev 1008)
+++ trunk/rkward/rkward/plugin/rkpluginspinbox.cpp	2006-12-15 14:15:25 UTC (rev 1009)
@@ -63,7 +63,6 @@
 		int initial = xml->getIntAttribute (element, "initial", min, DL_INFO);
 
 		spinbox->setIntMode (min, max, initial);
-		spinbox->setLineStep (initial > 1 ? initial : 1);
 
 		intvalue->setMin (min);
 		intvalue->setMax (max);

Modified: trunk/rkward/rkward/plugins/00saveload/load/source/description.xml
===================================================================
--- trunk/rkward/rkward/plugins/00saveload/load/source/description.xml	2006-12-13 17:38:16 UTC (rev 1008)
+++ trunk/rkward/rkward/plugins/00saveload/load/source/description.xml	2006-12-15 14:15:25 UTC (rev 1009)
@@ -18,7 +18,7 @@
 					<checkbox value_unchecked="FALSE" checked="false" value="TRUE" id="chdir" label="Change working directory" />
 					<checkbox value_unchecked="FALSE" checked="false" value="TRUE" id="printeval" label="Print eval" />
 					<input size="medium" initial = "getOption('prompt')" id="promptecho" label="Prompt"/>
-					<spinbox size="small" type="integer" id="maxdeparselength" min="1" initial="1" max="1000" label="Maximal length of 'echo'" />
+					<spinbox size="small" type="integer" id="maxdeparselength" min="1" initial="1" label="Maximal length of 'echo'" />
 					
 				</frame>
 			</tab>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.