RKWard is in kdereview

[Albert Astals Cid]

El dissabte, 6 d’octubre de 2018, a les 15:45:39 CEST, Thomas Friedrichsmeier va escriure:
> Hi!
> 
> KDE.org has been our home for a almost four years, now (after over a
> decade on sourceforge), but somehow I've kept procrastinating on the
> final step: Today I'd like to ask you to start reviewing RKWard for
> inclusion into exragear (coming from playground).


the i18n folder seems like from the past and something you should not need if in kde infrastructure. Could you delete it?

Also I'd suggest you compile enabling -DECM_ENABLE_SANITIZERS="address;undefined"

There's a few memory leaks (reported at exit) that you may want to have a look.

And there's also a few undefined behaviour warnings on exit, you've them marked as "known" things but it'd be good if you could find a way to fix them.

Your help menu is for some reason missing the Change Language option, i tried to do it a quick fix but could not, i would appreciate if you could find a way to only define the extra actions and not all of them (like we do for example in okular).

I've no idea about R so can't comment on the app itself ^_^

Cheers,
  Albert


> 
> RKWard is an easy to use and easily extensible IDE/GUI for R (a
> powerful language and environment for statistical computing, if you
> did not know it, yet). It aims to combine the power of the
> R-language with the ease of use of commercial statistics tools.
> 
> RKWard is used productively on Linux/BSD, Mac, and Windows.
> 
> We have quite a heavy code-base, and some of it dates back to the time
> when KDE 3.0 was still fresh. I guess reviewing this will not be an
> easy task, and honestly I have no idea where I would recommend you to
> start. So please just ask whatever you need to know, and I'll try my
> best to help you around.
> 
> Looking forward to your feedback!
> 
> Thomas Friedrichsmeier
> for the RKWard team