Cherry Pick Request for Frameworks 6.20 (and possibly 5 too?)
Nicolas Fella
nicolas.fella at gmx.de
Thu Nov 13 21:26:21 GMT 2025
Am 12.11.25 um 14:25 schrieb Oliver Schramm:
> Hey,
>
> the following commit unfortunately didn't make it quite in time for the Frameworks 6.20 tagging.
> So I wanted to ask, if you could cherry-pick it. And maybe even add it to a possible KF5 bugfix release, should there ever come one still. (Maybe you're collecting patches for 18 months, I don't know! 😅)
>
> Reason:
> It fixes a very unexpected behaviour that could lead to data loss.
> When users want to move a file to trash and the file is too big for the trash, the file instead gets deleted. If users have confirmations before deleting disabled, this will happen *without additional warning*!
>
> Because users probably do want a file gone they are moving to trash, I wouldn't say this is emergency-bugfix worthy. However, users *would* be able to restore a file if it's in trash. But since the app possibly does something the user doesn't want, the user won't have this choice anymore.
>
> This is also mentioned in the referenced bug: https://bugs.kde.org/show_bug.cgi?id=475235
>
> At the same time, it is a very unrisky bugfix, which only adds four lines of code. One for forcing the confirmation, three for disabling the "don't ask again"-checkbox which would save a wrong value.
>
> https://invent.kde.org/frameworks/kio/-/commit/52253584cd9e69a9920fa4396076a7b8c33c13f2
>
> Thank you very much!
>
> Greetings,
> Oliver
Hi,
done, it will be part of 6.20.
Thanks for the fix!
Cheers
Nico
More information about the release-team
mailing list