KDE Frameworks 5.65.0

[David Faure]

On jeudi 12 décembre 2019 23:26:38 CET José Manuel Santamaría Lema wrote:
> El domingo, 8 de diciembre de 2019 11:45:05 (CET) David Faure escribió:
> > Dear packagers,
> > 
> > KDE Frameworks 5.65.0 has been uploaded to the usual place.
> > 
> > New frameworks: KQuickCharts.
> > 
> > Public release next Saturday.
> > 
> > Thanks for the packaging work!
> 
> Hi David,
> 
> thanks as always for the tarballs. I have been working on Kubuntu's
> packaging and I have doubts about this symbol which was removed from KIO:
> void KDirOperator::keyPressEvent(QKeyEvent *e)
> 
> I have bisected to find out the commit which removed it and is this one:
> https://cgit.kde.org/kio.git/commit/?id=816fc6f9444fe70cdddc67b94e8027fdaab9
> 9c20
> 
> Also I re-checked the ABI issues list:
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#
> The_Do.27s_and_Don.27ts
> 
> Does this count as "Remove a virtual function, even if it is a
> reimplementation of a virtual function from the base class" which is in the
> "don'ts" list? Is this an ABI break?

You are very correct, this is indeed an ABI break.
My bad for approving this change, I do know better.

Fixed in https://commits.kde.org/kio/87ae22095c578d1316323dfdf03acc7a725a53cf

New tarball for KIO uploaded:

kio v5.65.0-rc2
2f04abc9b76dac6d40469e30de19fc8eb64f83c6
c787fa00cfc1d898d07605c46b3f92134038fa4761c422bf62a42beff7ceb743  sources/kio-5.65.0.tar.xz

Thanks for noticing!

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5