Review Request 129646: Fix the soname of kalzium internal libraries

[Luigi Toscano]

> On Dic. 13, 2016, 1:19 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 66
> > <https://git.reviewboard.kde.org/r/129646/diff/1/?file=487340#file487340line66>
> >
> >     This will need updating.
> >     
> >     How about using:
> >     ```
> >     # KDE Application Version, managed by release script
> >     set (KDE_APPLICATIONS_VERSION_MAJOR "16")
> >     set (KDE_APPLICATIONS_VERSION_MINOR "12")
> >     set (KDE_APPLICATIONS_VERSION_MICRO "0")
> >     ```
> >     
> >     Then have
> >     `set(LIBSOVERSION "${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")`

I did the exactly opposite change on few kdemultimedia modules. It is true that it's more likely for those libraries to became  part of Frameworks than those internal ones, and that starting with 16 (soon 17) means complications to go back to 5.
But... not sure.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129646/#review101400
-----------------------------------------------------------


On Dic. 13, 2016, 1:06 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129646/
> -----------------------------------------------------------
> 
> (Updated Dic. 13, 2016, 1:06 a.m.)
> 
> 
> Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr.
> 
> 
> Bugs: 373565
>     http://bugs.kde.org/show_bug.cgi?id=373565
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4.
> Define local variables for the version of the libraries.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9844a34 
>   compoundviewer/CMakeLists.txt 2109d84 
>   libscience/CMakeLists.txt d7c23a4 
> 
> Diff: https://git.reviewboard.kde.org/r/129646/diff/
> 
> 
> Testing
> -------
> 
> Compiles, and now:
> 
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so
> -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu"
> 
> I could not test the other library (I should compile avogadro) but I suspect that it should be the same.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20161213/2fe138f1/attachment.html>