Review Request 129646: Fix the soname of kalzium internal libraries

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129646/#review101400
-----------------------------------------------------------




CMakeLists.txt (line 66)
<https://git.reviewboard.kde.org/r/129646/#comment67890>

    This will need updating.
    
    How about using:
    ```
    # KDE Application Version, managed by release script
    set (KDE_APPLICATIONS_VERSION_MAJOR "16")
    set (KDE_APPLICATIONS_VERSION_MINOR "12")
    set (KDE_APPLICATIONS_VERSION_MICRO "0")
    ```
    
    Then have
    `set(LIBSOVERSION "${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")`


Sounds good to me if it's okay to keep track of changes.

- Aleix Pol Gonzalez


On Dec. 13, 2016, 1:06 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129646/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 1:06 a.m.)
> 
> 
> Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr.
> 
> 
> Bugs: 373565
>     http://bugs.kde.org/show_bug.cgi?id=373565
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4.
> Define local variables for the version of the libraries.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9844a34 
>   compoundviewer/CMakeLists.txt 2109d84 
>   libscience/CMakeLists.txt d7c23a4 
> 
> Diff: https://git.reviewboard.kde.org/r/129646/diff/
> 
> 
> Testing
> -------
> 
> Compiles, and now:
> 
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5
> -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so
> -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu"
> 
> I could not test the other library (I should compile avogadro) but I suspect that it should be the same.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20161213/4e77a6d8/attachment-0001.html>