KDE Frameworks 5.29.0

[Kevin Funk]

On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote:
> El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure va
> 
> escriure:
> > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote:
> > > Am 2016-12-05 09:20, schrieb David Faure:
> > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote:
> > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote:
> > > >> > Dear packagers,
> > > >> > 
> > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place.
> > > >> > 
> > > >> > New framework: prison
> > > >> > 
> > > >> > Public release next Saturday.
> > > >> > 
> > > >> > Thanks for the packaging work!
> > > >> 
> > > >> kconfig (r129382) breaks compilation of kdevplatform:
> > > >> http://paste.opensuse.org/82016854
> > > > 
> > > > Indeed (but it's not the change from RR 129382, it's commit cd4e650
> > > > from
> > > > https://phabricator.kde.org/D3386
> > > > 
> > > > Seems to come from Inherits=BaseClass while BaseClass doesn't use
> > > > arg="true".
> > > > 
> > > > Here's a testcase for the kconfig unittests. Martin, can you take a
> > > > look?
> > > 
> > > The earliest I can have a look is probably on Friday, I'm sorry.
> > > 
> > > My suggestion is to revert my two commits and I'll redo for next
> > > frameworks.
> > 
> > OK, done. New git tag and tarball:
> > 
> > kconfig v5.29.0-rc2
> > 47f7e954a58ba5538d055e2f75e483cade48ee8a
> > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47
> > sources/kconfig-5.29.0.tar.xz
> 
> Acoording to kfunk the thing that broke kdevplatform wasn't really kconfigs
> fault but a side effect of kdevplatform code not being very good.

Heya,

the patch restoring the kdevplatform build with KF5 5.29:
  https://cgit.kde.org/kdevplatform.git/commit/?
id=e84645d1694bdad7f179cd41babce723fe07aa63

The code in kdevplatform is a bit special, it's probably the only place in 
whole KDE which broke due to the recent changes in kconfig. I don't see an 
easy migration path, even if you introduce said change in a later kconfig 
release.

I don't mind if you leave kconfig as-is. But that's probably something for 
dfaure to decide.

Cheers,
Kevin


> I haven't read any of the diffs so i can't comment if this should be
> reverted or not, but just bringing in some of the IRC context i read.
> 
> Cheers,
>   Albert


-- 
Kevin Funk | kfunk at kde.org | http://kfunk.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/release-team/attachments/20161207/54de5c6b/attachment.sig>