Review Request 125544: Fix limit/offset handling when sort option is no sort.

Xuetian Weng wengxt at
Fri Oct 9 18:57:55 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 9, 2015, 6:57 p.m.)


This change has been marked as submitted.

Review request for Baloo, Release Team and Vishesh Handa.


Submitted with commit 64c57e56fe3392cf057ac2948cddb1e5a011a0c1 by Weng Xuetian to branch master.

Repository: baloo


The bug is obvious, old code uses limit instead of (limit > 0), which gracefully handles limit < 0 case (means everything).

After offset is introduced, limit < 0 case is not handled properly.

This patch contains following changes:
1. make offset uint, m_offset is uint in Query already.
2. handle limit < 0 case properly.

Also fix offset with sorting.


  src/lib/searchstore.h 17b4263 
  src/lib/searchstore.cpp a2e7749 



baloosearch:/ doesn't return anything because of this, now it properly returns result.

Play with baloosearch command a little bit, offset and limit returns the [offset, offset + limit) and no crash on the border case.


Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the release-team mailing list