Review Request 124801: set cmake_min_req to match kdelibs policy and enable newer cmake policies

[Albert Astals Cid]

> On ago. 22, 2015, 10:23 a.m., Urs Wolfer wrote:
> > So do you still think cherry-picking of c8789dd6546c8fd8d00e4c0ed1ac8fa48d337acf into Applications/15.08 is required (I'm not sure because of the discussion)? Do other apps also have this line in Applications/15.08?

I guess it won't hurt, but it's not *required* since as far as i can see it builds fine in jenkins https://build.kde.org/job/krdc%20Applications-15.08%20stable-qt4/


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124801/#review84182
-----------------------------------------------------------


On ago. 18, 2015, 9:55 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124801/
> -----------------------------------------------------------
> 
> (Updated ago. 18, 2015, 9:55 a.m.)
> 
> 
> Review request for Release Team and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> This is just a cherry-pick of c8789dd6546c8fd8d00e4c0ed1ac8fa48d337acf from master. With the recent cmake changes to kdelibs>4.14.10 krdc fails to build with newer cmake versions with the error below. Adding the release-team, because it touches a dependency requirement and this patch might be nice to have in the 15.08.0 tarball.
> 
> Error:
>   * In program cave perform install --hooks --managed-output --output-exclusivity with-others =kde/krdc-15.08.0:4::kde --destination installed --replacing =kde/krdc-15.08.0:4::installed --x-of-y 1 of 1:
>   * When installing 'kde/krdc-15.08.0:4::kde' replacing { 'kde/krdc-15.08.0:4::installed' }:
>   * When running an ebuild command on 'kde/krdc-15.08.0:4::kde':
>   * Install failed for 'kde/krdc-15.08.0:4::kde' (paludis::ActionFailedError)
> 
> -- Configuring incomplete, errors occurred!
> See also "/var/tmp/paludis/build/kde-krdc-15.08.0/work/build/CMakeFiles/CMakeOutput.log".
> See also "/var/tmp/paludis/build/kde-krdc-15.08.0/work/build/CMakeFiles/CMakeError.log".
> CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:112 (elseif):
>   given arguments:
> 
>     "VERSION_LESS" "3.1"
> 
>   Unknown arguments specified
> Call Stack (most recent call first):
>   /usr/share/cmake/Modules/FindPkgConfig.cmake:501 (_pkgconfig_parse_options)
>   /usr/share/cmake/Modules/FindOpenSSL.cmake:43 (pkg_check_modules)
>   /usr/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 (FIND_PACKAGE)
>   /usr/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE)
>   /usr/share/apps/cmake/modules/FindKDE4Internal.cmake:395 (find_package)
>   /usr/share/cmake/Modules/FindKDE4.cmake:108 (find_package)
>   CMakeLists.txt:6 (find_package)
> 
> 
> CMake Warning (dev) in CMakeLists.txt:
>   No cmake_minimum_required command is present.  A line of code such as
> 
>     cmake_minimum_required(VERSION 3.3)
> 
>   should be added at the top of the file.  The version specified may be lower
>   if you wish to support older CMake versions for this project.  For more
>   information run "cmake --help-policy CMP0000".
> This warning is for project developers.  Use -Wno-dev to suppress it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 26417cf89c5bf54283be4c03b642d280e62758c2 
> 
> Diff: https://git.reviewboard.kde.org/r/124801/diff/
> 
> 
> Testing
> -------
> 
> Successfully built against kdelibs-4.14.11 and cmake 3.3.1.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20150822/9f92a2d5/attachment.html>