<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124801/">https://git.reviewboard.kde.org/r/124801/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On agost 22nd, 2015, 10:23 a.m. UTC, <b>Urs Wolfer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So do you still think cherry-picking of c8789dd6546c8fd8d00e4c0ed1ac8fa48d337acf into Applications/15.08 is required (I'm not sure because of the discussion)? Do other apps also have this line in Applications/15.08?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess it won't hurt, but it's not <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">required</em> since as far as i can see it builds fine in jenkins https://build.kde.org/job/krdc%20Applications-15.08%20stable-qt4/</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On agost 18th, 2015, 9:55 a.m. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Release Team and Urs Wolfer.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated ago. 18, 2015, 9:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
krdc
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is just a cherry-pick of c8789dd6546c8fd8d00e4c0ed1ac8fa48d337acf from master. With the recent cmake changes to kdelibs>4.14.10 krdc fails to build with newer cmake versions with the error below. Adding the release-team, because it touches a dependency requirement and this patch might be nice to have in the 15.08.0 tarball.
Error:
* In program cave perform install --hooks --managed-output --output-exclusivity with-others =kde/krdc-15.08.0:4::kde --destination installed --replacing =kde/krdc-15.08.0:4::installed --x-of-y 1 of 1:
* When installing 'kde/krdc-15.08.0:4::kde' replacing { 'kde/krdc-15.08.0:4::installed' }:
* When running an ebuild command on 'kde/krdc-15.08.0:4::kde':
* Install failed for 'kde/krdc-15.08.0:4::kde' (paludis::ActionFailedError)
-- Configuring incomplete, errors occurred!
See also "/var/tmp/paludis/build/kde-krdc-15.08.0/work/build/CMakeFiles/CMakeOutput.log".
See also "/var/tmp/paludis/build/kde-krdc-15.08.0/work/build/CMakeFiles/CMakeError.log".
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:112 (elseif):
given arguments:
"VERSION_LESS" "3.1"
Unknown arguments specified
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPkgConfig.cmake:501 (_pkgconfig_parse_options)
/usr/share/cmake/Modules/FindOpenSSL.cmake:43 (pkg_check_modules)
/usr/share/apps/cmake/modules/Qt4ConfigDependentSettings.cmake:224 (FIND_PACKAGE)
/usr/share/apps/cmake/modules/FindQt4.cmake:1207 (INCLUDE)
/usr/share/apps/cmake/modules/FindKDE4Internal.cmake:395 (find_package)
/usr/share/cmake/Modules/FindKDE4.cmake:108 (find_package)
CMakeLists.txt:6 (find_package)
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of code such as
cmake_minimum_required(VERSION 3.3)
should be added at the top of the file. The version specified may be lower
if you wish to support older CMake versions for this project. For more
information run "cmake --help-policy CMP0000".
This warning is for project developers. Use -Wno-dev to suppress it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully built against kdelibs-4.14.11 and cmake 3.3.1.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(26417cf89c5bf54283be4c03b642d280e62758c2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124801/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>