Review Request 124801: set cmake_min_req to match kdelibs policy and enable newer cmake policies

[Rolf Eike Beer]

Am Dienstag, 18. August 2015, 09:55:49 schrieb Heiko Becker:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124801/
> -----------------------------------------------------------
> 
> Review request for Release Team and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> This is just a cherry-pick of c8789dd6546c8fd8d00e4c0ed1ac8fa48d337acf from
> master. With the recent cmake changes to kdelibs>4.14.10 krdc fails to
> build with newer cmake versions with the error below. Adding the
> release-team, because it touches a dependency requirement and this patch
> might be nice to have in the 15.08.0 tarball.
> 
> Error:
>   * In program cave perform install --hooks --managed-output
> --output-exclusivity with-others =kde/krdc-15.08.0:4::kde --destination
> installed --replacing =kde/krdc-15.08.0:4::installed --x-of-y 1 of 1: *
> When installing 'kde/krdc-15.08.0:4::kde' replacing {
> 'kde/krdc-15.08.0:4::installed' }: * When running an ebuild command on
> 'kde/krdc-15.08.0:4::kde':
>   * Install failed for 'kde/krdc-15.08.0:4::kde'
> (paludis::ActionFailedError)
> 
> -- Configuring incomplete, errors occurred!
> See also
> "/var/tmp/paludis/build/kde-krdc-15.08.0/work/build/CMakeFiles/CMakeOutput.
> log". See also
> "/var/tmp/paludis/build/kde-krdc-15.08.0/work/build/CMakeFiles/CMakeError.l
> og". CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:112
> (elseif): given arguments:
> 
>     "VERSION_LESS" "3.1"

Uhm, it's actually CMake that is broken here. Go ahead with the patch, I have 
pushed a patch to fix CMake here:

http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b9ec9392da21a3421e48c6961976060d872faffb

diff --git a/Modules/FindPkgConfig.cmake b/Modules/FindPkgConfig.cmake
index 526a62e..ae6903e 100644
--- a/Modules/FindPkgConfig.cmake
+++ b/Modules/FindPkgConfig.cmake
@@ -109,7 +109,7 @@ macro(_pkgconfig_parse_options _result _is_req _is_silent 
_no_cmake_path _no_cma
       set(${_no_cmake_path} 1)
       set(${_no_cmake_environment_path} 1)
     endif()
-  elseif(${CMAKE_MINIMUM_REQUIRED_VERSION} VERSION_LESS 3.1)
+  elseif(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 3.1)
     set(${_no_cmake_path} 1)
     set(${_no_cmake_environment_path} 1)
   endif()

Greetings,

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/release-team/attachments/20150818/7a9f90eb/attachment.sig>