Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111000/#review34403
-----------------------------------------------------------

Ship it!


Yes, this is fine.

I won't create trouble in KF5 since the whole subdir has been deleted from kdelibs, since it will come from the kate.git repo.


interfaces/ktexteditor/messageinterface.h
<http://git.reviewboard.kde.org/r/111000/#comment25273>

    Is the '%' on purpose?



interfaces/ktexteditor/messageinterface.h
<http://git.reviewboard.kde.org/r/111000/#comment25272>

    extra-qualification will break some compilers. This should just be AutoHideMode, no?


- David Faure


On June 15, 2013, 6:18 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111000/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 6:18 p.m.)
> 
> 
> Review request for Kate, kdelibs, Release Team, Christoph Cullmann, and David Faure.
> 
> 
> Description
> -------
> 
> This patch adds the KTextEditor::MessageInterface to the KTextEditor interfaces in kdelibs 4.11.
> 
> This interface exists in Kate since KDE 4.10, and is already used internally to show messages when needed (e.g. search & replace, or swap file recover bar). By adding this interface to kdelibs, applications like KDevelop, Kile, etc... can use this interface to show passive interactive notifications in a KTextEditor::View.
> 
> With this commit, we also want to get feedback by potential users of this interface, so we can improve/tweak it again for KDE 5 (or whatever it will be called :) ).
> 
> 
> Diffs
> -----
> 
>   interfaces/ktexteditor/messageinterface.cpp PRE-CREATION 
>   interfaces/ktexteditor/messageinterface.h PRE-CREATION 
>   interfaces/ktexteditor/CMakeLists.txt 9813734 
>   includes/KTextEditor/MessageInterface PRE-CREATION 
>   includes/KTextEditor/Message PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111000/diff/
> 
> 
> Testing
> -------
> 
> Given the interface is in Kate since KDE 4.10, the interface is quite mature.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130615/e822fdb6/attachment-0001.html>