Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

Albert Astals Cid aacid at kde.org
Sat Jun 15 18:18:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111000/
-----------------------------------------------------------

(Updated June 15, 2013, 6:18 p.m.)


Review request for Kate, kdelibs, Release Team, Christoph Cullmann, and David Faure.


Changes
-------

David, this is "new code" (actually moved code) that wants an exception for kdelibs/interfaces, do you agree to get it in?


Description
-------

This patch adds the KTextEditor::MessageInterface to the KTextEditor interfaces in kdelibs 4.11.

This interface exists in Kate since KDE 4.10, and is already used internally to show messages when needed (e.g. search & replace, or swap file recover bar). By adding this interface to kdelibs, applications like KDevelop, Kile, etc... can use this interface to show passive interactive notifications in a KTextEditor::View.

With this commit, we also want to get feedback by potential users of this interface, so we can improve/tweak it again for KDE 5 (or whatever it will be called :) ).


Diffs
-----

  interfaces/ktexteditor/messageinterface.cpp PRE-CREATION 
  interfaces/ktexteditor/messageinterface.h PRE-CREATION 
  interfaces/ktexteditor/CMakeLists.txt 9813734 
  includes/KTextEditor/MessageInterface PRE-CREATION 
  includes/KTextEditor/Message PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111000/diff/


Testing
-------

Given the interface is in Kate since KDE 4.10, the interface is quite mature.


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130615/d218a5d3/attachment.html>


More information about the release-team mailing list