Review Request 108516: Do not hardcode site-packages for the python libdir.

[Harry Miller]

Hi
"Need someone to check when installing into /usr."
I've tested the python patch on kde 4.9.98 and installed it into /usr/lib64/ and haven't had anything go wrong...  yet ;) 

--- On Tue, 1/22/13, Albert Astals Cid <aacid at kde.org> wrote:

From: Albert Astals Cid <aacid at kde.org>
Subject: Re: Review Request 108516: Do not hardcode site-packages for the python libdir.
To: "Kevin Kofler" <kevin.kofler at chello.at>
Cc: "Albert Astals Cid" <aacid at kde.org>, "Release Team" <release-team at kde.org>, "Build System" <kde-buildsystem at kde.org>
Date: Tuesday, January 22, 2013, 12:27 PM





 
  
   
    
     
      This is an automatically generated e-mail. To reply, visit:
      http://git.reviewboard.kde.org/r/108516/
     
    
   
   






 Personally and from a "I know nothing about python" perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment.

I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard.

So could this as a half-shipit.

I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D
 










- Albert




On January 21st, 2013, 11 a.m. UTC, Michael Jansen wrote:







 
  

Review request for Build System, Release Team and Kevin Kofler.
By Michael Jansen.


Updated Jan. 21, 2013, 11 a.m.






Description 
 
 
  
   Do not hardcode site-packages for the python libdir.
  
 



Testing 

 
  
   Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr.

I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it?
  
 





Diffs 


 cmake/modules/FindPythonLibrary.cmake (7cef79b16521c759f38f1deea539a28a50c5d708)



View Diff







  
 









  
 



-----Inline Attachment Follows-----

_______________________________________________
release-team mailing list
release-team at kde.org
https://mail.kde.org/mailman/listinfo/release-team
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130122/c33689be/attachment.html>