<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;">Hi<br><pre id="testing_done" class="editable" style="font-size: 10pt; white-space: pre-wrap; word-wrap: break-word; background-color: rgb(255, 255, 255); border: 1px solid rgb(184, 181, 160); margin-top: 5px; margin-bottom: 0px; padding: 10px;">"Need someone to check when installing into /usr."</pre><br>I've tested the python patch on kde 4.9.98 and installed it into /usr/lib64/ and haven't had anything go wrong... yet ;) <br><br>--- On <b>Tue, 1/22/13, Albert Astals Cid <i><aacid@kde.org></i></b> wrote:<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><br>From: Albert Astals Cid <aacid@kde.org><br>Subject: Re: Review Request 108516: Do not hardcode site-packages for the python libdir.<br>To: "Kevin Kofler" <kevin.kofler@chello.at><br>Cc: "Albert Astals Cid" <aacid@kde.org>,
"Release Team" <release-team@kde.org>, "Build System" <kde-buildsystem@kde.org><br>Date: Tuesday, January 22, 2013, 12:27 PM<br><br><div id="yiv1932684674">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid;">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a rel="nofollow" target="_blank" href="http://git.reviewboard.kde.org/r/108516/">http://git.reviewboard.kde.org/r/108516/</a>
</td>
</tr>
</tbody></table>
<br>
<pre style="white-space:pre-wrap;word-wrap:break-word;">Personally and from a "I know nothing about python" perspective, I'd prefer this to not go to 4.10.0, seems like something a bit fragile that might break and we can't really afford that in 4.10.0 at the moment.
I wouldn't mind seening it in master if you think that fixing the problems that might arise in the future should not be hard.
So could this as a half-shipit.
I'd like Kevin, Luca, Christophe to comment here too, but we can't all get what we want :D</pre>
<br>
<p>- Albert</p>
<br>
<p>On January 21st, 2013, 11 a.m. UTC, Michael Jansen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-position:left top;background-repeat:repeat-x;border:1px black solid;">
<tbody><tr>
<td>
<div>Review request for Build System, Release Team and Kevin Kofler.</div>
<div>By Michael Jansen.</div>
<p style="color:grey;"><i>Updated Jan. 21, 2013, 11 a.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0;">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;word-wrap:break-word;">Do not hardcode site-packages for the python libdir.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0;">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;word-wrap:break-word;">Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr.
I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it?</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em;">Diffs </h1>
<ul style="margin-left:3em;padding-left:0;">
<li>cmake/modules/FindPythonLibrary.cmake <span style="color:grey;">(7cef79b16521c759f38f1deea539a28a50c5d708)</span></li>
</ul>
<p><a rel="nofollow" target="_blank" href="http://git.reviewboard.kde.org/r/108516/diff/" style="margin-left:3em;">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</div><br>-----Inline Attachment Follows-----<br><br><div class="plainMail">_______________________________________________<br>release-team mailing list<br><a ymailto="mailto:release-team@kde.org" href="/mc/compose?to=release-team@kde.org">release-team@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/release-team" target="_blank">https://mail.kde.org/mailman/listinfo/release-team</a><br></div></blockquote></td></tr></table>