Review Request 111949: Backup ResourceListGenerator: Do not only count files with tags
Simeon Bird
bladud at gmail.com
Fri Aug 9 19:29:22 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111949/#review37447
-----------------------------------------------------------
Ship it!
again, not super-familiar with this code, but for what my opinion is worth, it looks good.
- Simeon Bird
On Aug. 8, 2013, 7:04 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111949/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 7:04 p.m.)
>
>
> Review request for Nepomuk and Release Team.
>
>
> Description
> -------
>
> Only files with tags used to be backed up. If a file had only a rating
> or a comment then its information would not be backed up.
>
>
> Diffs
> -----
>
> autotests/test/backuptests.cpp 7284dd6
> services/storage/backup/resourcelistgenerator.cpp 059bfa7
>
> Diff: http://git.reviewboard.kde.org/r/111949/diff/
>
>
> Testing
> -------
>
> Tested by manually backing up a number of times.
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20130809/38963eb6/attachment.html>
More information about the release-team
mailing list