Can i still merge this, small KDirWatch improvement.

[Albert Astals Cid]

> On Wednesday 07 August 2013 10:12:48 Albert Astals Cid wrote:

> > > On Wednesday 07 August 2013 09:38:51 Albert Astals Cid wrote:
> > > > > Hi Release team,
> > > > 
> > > > Hi
> > > > 
> > > > > I just got the OK to ship [1] but considering the very close release
> > > > > of KDE 4.11 it seems right to ask the release team for permission as
> > > > > well.
> > > > > 
> > > > > The patch simply prevents one stat call with KDirWatch and makes the
> > > > > code a little bit better to understand. Tests pass just fine and othe
> > > > > additional (visual and gdb) testing hasn't shown any regression.
> > > > > 
> > > > > If i am not allowed to push it (due to the very close 4.11 tag), when
> > > > > can i push it then? Right after the tag i assume?
> > > > 
> > > > Honestly, if this is just a [small] speed optimization and doesn't fix
> > > > any
> > > > bug, i don't see it belonging to 4.11 at all, just commit it to master
> > > > and
> > > > leave it for 4.12.
> > > > 
> > > > Unless is a so huge optimization our users are going to send us money
> > > > for
> > > > the speed difference :D
> > > 
> > > Don't want to interfere with the release team work - but, if 4.11 is going
> > > to be a long term maintained version (and it is) doesn't it make sense to
> > > let this go in during say 4.11.3 or so (it would've gotten some more
> > > testing by then)? Otherwise, this won't reach users for a long time - and
> > > that's neither very motivating nor benefiting anybody.
> > 
> > The only thing long term in 4.11 is kde-workspace, this is not
> > kde-workspace, so your rationale doesn't apply.
> 
> It's KDELibs then? 

Yes, you'll see if you click on the link

Repository: kdelibs

> The rationale is kind'a the same - Frameworks 5 is still a 
> while off, it seems sensible to let users benefit from a slightly more liberal 
> policy with regards to our .x releases until the 5 series arrives on the 
> scene. Even if not for this patch, don't you think it makes sense to adopt a 
> similar policy as we did in the KDE 3.5 times?

Errr, what? There will be a 4.12 kdelibs release, so no, the rationale is not similar at all to the kde-workspace situation.

Cheers,
  Albert

> 
> > > > > [1] https://git.reviewboard.kde.org/r/111870/