Can i still merge this, small KDirWatch improvement.
Albert Astals Cid
aacid at kde.org
Wed Aug 7 08:38:51 UTC 2013
> Hi Release team,
Hi
>
> I just got the OK to ship [1] but considering the very close release
> of KDE 4.11 it seems right to ask the release team for permission as
> well.
>
> The patch simply prevents one stat call with KDirWatch and makes the
> code a little bit better to understand. Tests pass just fine and othe
> additional (visual and gdb) testing hasn't shown any regression.
>
> If i am not allowed to push it (due to the very close 4.11 tag), when
> can i push it then? Right after the tag i assume?
Honestly, if this is just a [small] speed optimization and doesn't fix any bug, i don't see it belonging to 4.11 at all, just commit it to master and leave it for 4.12.
Unless is a so huge optimization our users are going to send us money for the speed difference :D
Cheers,
Albert
>
> Kind regards,
> Mark
>
> [1] https://git.reviewboard.kde.org/r/111870/
More information about the release-team
mailing list