Review Request: refactoring of import wizard to be able to show errors

Albert Astals Cid aacid at kde.org
Tue Jul 10 20:29:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7003/#review10874
-----------------------------------------------------------

Ship it!


Code looks sane and you got no objection from i18n teams, feel free to commit and if you're fast enough it'll be part of RC2

- Albert Astals Cid


On July 2, 2012, 4:55 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7003/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 4:55 p.m.)
> 
> 
> Review request for Release Team.
> 
> 
> Description
> -------
> 
> The appended git patch (uploaded as file) refactors the code import wizard to be able to show import errors. This patch contains i18n string changes. 
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=302671.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=302671
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://svn.reviewboard.kde.org/r/7003/diff/
> 
> 
> Testing
> -------
> 
> works well in trunk 
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20120710/9352dd14/attachment.html>


More information about the release-team mailing list