Review Request: ResourceManager: Do not double initalize the NepomukMainModel

Commit Hook null at kde.org
Tue Jul 3 12:19:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105281/#review15338
-----------------------------------------------------------


This review has been submitted with commit 847d642f876507bda220750468afbba3adbccbfa by Vishesh Handa to branch KDE/4.9.

- Commit Hook


On June 26, 2012, 9:06 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105281/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 9:06 a.m.)
> 
> 
> Review request for Nepomuk, Release Team and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> ResourceManager: Do not double initalize the NepomukMainModel
> 
> The NepomukMainModel is initalized once when it is created and then the
> second time in ResourceManager::init.
> 
> This results in a second connection being made to nepomukstorage, and an
> extra thread being spawned over there. The old thread is eventually
> deleted, but the whole process is rather pointless.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/nepomukmainmodel.cpp a11faae9a6d42806ba884e74f07e2d0113c6910f 
> 
> Diff: http://git.reviewboard.kde.org/r/105281/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/release-team/attachments/20120703/643bb3eb/attachment.html>


More information about the release-team mailing list