Commit patch to KDE/4.7 from reviewboard, no translation string and fixes two bugs

[Lamarque Vieira Souza]

Em dom 10 jul 2011, Albert Astals Cid:
> Em sáb 09 jul 2011, Lamarque Vieira Souza escreveu:
> > 	Hi all,
> > 
> > 	Can I commit this patch to branch KDE/4.7?
> > https://svn.reviewboard.kde.org/r/6513/
> > 
> > 	It looks simple (touches only one .cpp and its .h) yet solves two bugs
> > and there is no translation strings. The patch has been in revieboard for
> > more than four months, it should have been applied to 4.6 already.
> 
> I don't think the release team is the one that can give you an answer to 
that.
> 
> As far as I can see it fixes a bug in krandr & friends. You should get the
> OK from the maintainers of that code. Given that there is probably no
> maintainers for it, you are probably the remaining most knowledgeable person
> about that code, so anything we say it's just going to be thumbsucking
> answers.

	Well, the problem is that I sent an e-mail three months ago asking the 
same question and nobody has answered me.
 
> So i guess the question is:
> How sure are you about this patch fixing the bug and not introducing worst 
> consquences?

	At least one person besides me and the patch creator test it and we have 
not find any side effects so far.

>  And in case it introduces bugs will you be around to fix them?

	Yes.
 
> If the answers are "quite" and "yes", i don't see why you should not commit 
> it.

	Ok, I will commit it.

-- 
Lamarque V. Souza
http://www.geographicguide.com/brazil.htm
Linux User #57137 - http://counter.li.org/
http://planetkde.org/pt-br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/release-team/attachments/20110710/9a269052/attachment.htm