KDE/kdelibs/cmake/modules

[Alexander Neundorf]

On Friday 04 January 2008, Lubos Lunak wrote:
> On Friday 04 of January 2008, Alexander Neundorf wrote:
> > On Thursday 03 January 2008, Luboš Luňák wrote:
> > > SVN commit 756696 by lunakl:
> > >
> > > Consistent naming for xf86misc - include and flag are xf86misc, lib is
> > > Xxf86misc.
> >
> > I'm not sure this change is good:
> >
> > This is a source incompatible change.
> > Somebody may use these variables and now they don't exist anymore, so his
> > build may fail.
>
>  It will at most not detect the feature, but even then that's very
> unlikely, as xf86misc is only very special functionality.

Yes, it is very unlikely, but very unlikely != impossible.
The thing is, the names were in sync with the names of the variables in the 
FindX11.cmake of cmake cvs since several months.
So since several months some cmake cvs users may already use that variable. 
Ok, it is the cvs version only, but still it is there for quite some time 
already and changing this can break the build of somebody (you never know 
what somebody does with the variables). So this change means either we can 
never use the module from cmake or I need to add some transition logic on the 
cmake side. 
So is it really necessary to change the name ?

> > We are at the day of the tagging, IMO too late for such changes.
>
>  It was broken.

In which way was it exactly broken ?

Alex