KDE/kdelibs

Thomas Zander zander at kde.org
Wed Dec 5 10:03:33 CET 2007


On Tuesday 4. December 2007 19:38:07 Dirk Mueller wrote:
> On Monday 03 December 2007, Hamish Rodda wrote:
> > Replace KAction::associateWidget() with a set of methods to permanently
> > associate / dissociate a widget with an action collection.  This does not
> > change the shortcut context, in contrast to the methods that I removed
> > about a month ago; this approach was thought to be ok (in comparison to
> > the one I removed) because it does not cause modification of the actions
> > being added to the collection.
> >
> > Also, add all xmlgui client actions to the top level main window.
> >
> > These two changes fix bug 151421 and duplicates / related bugs.
> >
> > It is BIC as I have removed the old associateWidget(), for which I will
> > commit patches to the rest of KDE which use it now.
>
> even worse, it is source incompatible. Did you notice that we have released
> a stable platform that is now broken again?
>
> can the associateWidget() call be restored?

Would be nice if this was replied to his repeated requests for feedback on 
k-c-d where he pointed out the incompatibility. :(

Since it didn't, and he fixed all of kde-svn, I'm not particularly in favor of 
the requested revert...
-- 
Thomas Zander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/release-team/attachments/20071205/22e4620e/attachment.pgp 


More information about the release-team mailing list