[rekonq] Review Request: Refactoring Code to Load Configuration Document

David Narváez david.narvaez at computer.org
Wed Jan 18 05:18:45 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103722/
-----------------------------------------------------------

Review request for rekonq.


Description
-------

Factor out all code that loads the DOM Document, and use proper calls in each method. The idea is pretty straightforward, I guess we only need to agree on the style (e.g., should it be a private method or just a function?)

Can this go into 0.9? Or is it considered a feature?


Diffs
-----

  src/sessionmanager.cpp e67012a 

Diff: http://git.reviewboard.kde.org/r/103722/diff/diff


Testing
-------

I've been using this for about a week, no changes wrt to previous behavior. I started new sessions, restored previous sessions, crashed sessions... I think those are all use cases that cover these lines of code.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120118/78180972/attachment.html>


More information about the rekonq mailing list