[rekonq] Review Request: Hook the urlChanged Signal to History Actions Update

Commit Hook null at kde.org
Tue Feb 21 07:32:00 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104035/#review10778
-----------------------------------------------------------


This review has been submitted with commit 79c808a25d680b5782c63f02258b3d0492d55f05 by David E. Narváez to branch master.

- Commit Hook


On Feb. 21, 2012, 1:43 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104035/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2012, 1:43 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> This catches navigation to named anchors. I'm not sure if this is the right way, since this could be stepping on any other chain of signal/slots that update the history actions.
> 
> 
> This addresses bug 294538.
>     /show_bug.cgi?id=294538
> 
> 
> Diffs
> -----
> 
>   src/mainview.cpp 8c63763 
> 
> Diff: http://git.reviewboard.kde.org/r/104035/diff/
> 
> 
> Testing
> -------
> 
> Use steps to reproduce bug 294538, notice the back arrow is updated on step 3.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120221/b7d82c5c/attachment.html>


More information about the rekonq mailing list