[rekonq] Review Request: Hook the urlChanged Signal to History Actions Update
Andrea Diamantini
adjam7 at gmail.com
Tue Feb 21 07:16:54 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104035/#review10777
-----------------------------------------------------------
Ship it!
Your change seems safe. Please merge it in master/Branches.0.9
- Andrea Diamantini
On Feb. 21, 2012, 1:43 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104035/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2012, 1:43 a.m.)
>
>
> Review request for rekonq.
>
>
> Description
> -------
>
> This catches navigation to named anchors. I'm not sure if this is the right way, since this could be stepping on any other chain of signal/slots that update the history actions.
>
>
> This addresses bug 294538.
> /show_bug.cgi?id=294538
>
>
> Diffs
> -----
>
> src/mainview.cpp 8c63763
>
> Diff: http://git.reviewboard.kde.org/r/104035/diff/
>
>
> Testing
> -------
>
> Use steps to reproduce bug 294538, notice the back arrow is updated on step 3.
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20120221/1070ac4d/attachment.html>
More information about the rekonq
mailing list