[rekonq] Review Request: delay in notifypopup

[Johannes Tröscher]

> On Sept. 13, 2011, 9:02 a.m., Andrea Diamantini wrote:
> > I don't clearly understand the utility of delaying it. Can someone enlight me, please? I noticed that Firefox does, while Chrome don't. And testing it, I'm quite about Chrome's behavior. Others?

https://bugs.kde.org/show_bug.cgi?id=224276
i did just implement it, because there exists a bug report for the feature. i think it's a bit better because it behaves like normal tooltips and i tend to go always the firefox way because i like it more than chromium, but if the majority is against it i wouldn't care if it wouldn't get merged.


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102586/#review6474
-----------------------------------------------------------


On Sept. 12, 2011, 10:15 a.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102586/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 10:15 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> adds a 500ms delay for notifypopup, like in firefox.
> fixes bug: https://bugs.kde.org/show_bug.cgi?id=238951
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h c2654a9 
>   src/mainwindow.cpp d1650f3 
> 
> Diff: http://git.reviewboard.kde.org/r/102586/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110913/7c45dd21/attachment.html>