[rekonq] Review Request: delay in notifypopup
Andrea Diamantini
adjam7 at gmail.com
Tue Sep 13 09:02:09 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102586/#review6474
-----------------------------------------------------------
I don't clearly understand the utility of delaying it. Can someone enlight me, please? I noticed that Firefox does, while Chrome don't. And testing it, I'm quite about Chrome's behavior. Others?
- Andrea
On Sept. 12, 2011, 10:15 a.m., Johannes Tröscher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102586/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2011, 10:15 a.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> adds a 500ms delay for notifypopup, like in firefox.
> fixes bug: https://bugs.kde.org/show_bug.cgi?id=238951
>
>
> Diffs
> -----
>
> src/mainwindow.h c2654a9
> src/mainwindow.cpp d1650f3
>
> Diff: http://git.reviewboard.kde.org/r/102586/diff
>
>
> Testing
> -------
>
> compiles and works
>
>
> Thanks,
>
> Johannes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110913/97833ad2/attachment.html>
More information about the rekonq
mailing list