[rekonq] Review Request: Improve WebKit Settings

[Pierre Rossi]

> On Oct. 26, 2011, 3:36 p.m., Pierre Rossi wrote:
> > Huh. I've been totally under the radar and much involved for a while (and I feel bad about it), but I fail to see how we're gonna get WebGL working... Last I checked it still required a QGraphicsWebView with a GL viewport. Not a direction I feel worth investing in at that point (graphics view is not really the future, I guess starting some work on KDEWebKit for WebKit2 is probably a more worthy time investment, if anybody's interested)
> 
> Andrea Diamantini wrote:
>     Stupid me! You are totally right, Pierre! I was just checking QtWebKit 2.2 code and comparing with QtWebKit 2.0.x one to desume new features. And I forgot one particular.... Is it ok to just remove WebGL settings from new widget?
> 
> Andrea Diamantini wrote:
>     About KDEWebKit, I'm seeing you (QtWebKitters) are yet debating about WebKit2 API to expose. Isn't it a bit too early to start working on it? Moreover, are you thinking about the usual KDE layer over QtWebKit or about a full KDE port?

KDEWebKit:

Thinking about a full-fledged port. Sure that's some long term plan I have in mind. Right now is really early, I'm just thinking a bunch of people are going to have to start pioneering and experimenting there. I am an obvious candidate, and I think other QtWebKittens might help too but we'll probably need more people. We'll also need to see what it would mean for rekonq, maybe we can start getting ready, slowly tidying up our code base to see which things we'd reuse, what we'd have to change, the sprint seems like a good time to talk about all this, and maybe start prototyping. On a side note, the INdT guys have a pretty cool web browser, snowshoe, running on top of Qt/WebKit2, check it out it's on github.

On this particular settings topic: 
sure, no worries for WebGL, as for frame flattening, I can't really see where it's setting it in your patch, and I'm not really sure it's something we want in rekonq, it's very specific to touch enabled devices IMO. 


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102920/#review7662
-----------------------------------------------------------


On Oct. 23, 2011, 2:22 p.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102920/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 2:22 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> This patch changes WebKit Settings window removing the "unuseful" stuffs and adding some news like WebGL or Frame Flattening (probably useful also on netbook).
> 
> Let us require QtWebKit 2.2.x, hence Qt 4.8.0 at least until someone will explain me how I can check QtWebKit version number with cmake...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0c52471 
>   src/application.cpp d770b3d 
>   src/rekonq.kcfg d29a5a3 
>   src/settings/settings_webkit.ui 58fbe45 
>   src/settings/webkitwidget.h d143510 
>   src/settings/webkitwidget.cpp 04242af 
> 
> Diff: http://git.reviewboard.kde.org/r/102920/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> new WebKit settings
>   http://git.reviewboard.kde.org/r/102920/s/315/
> 
> 
> Thanks,
> 
> Andrea Diamantini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111026/0b4c506d/attachment-0001.html>