<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102920/">http://git.reviewboard.kde.org/r/102920/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 26th, 2011, 3:36 p.m., <b>Pierre Rossi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh. I've been totally under the radar and much involved for a while (and I feel bad about it), but I fail to see how we're gonna get WebGL working... Last I checked it still required a QGraphicsWebView with a GL viewport. Not a direction I feel worth investing in at that point (graphics view is not really the future, I guess starting some work on KDEWebKit for WebKit2 is probably a more worthy time investment, if anybody's interested)</pre>
</blockquote>
<p>On October 26th, 2011, 3:55 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stupid me! You are totally right, Pierre! I was just checking QtWebKit 2.2 code and comparing with QtWebKit 2.0.x one to desume new features. And I forgot one particular.... Is it ok to just remove WebGL settings from new widget?</pre>
</blockquote>
<p>On October 26th, 2011, 3:58 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">About KDEWebKit, I'm seeing you (QtWebKitters) are yet debating about WebKit2 API to expose. Isn't it a bit too early to start working on it? Moreover, are you thinking about the usual KDE layer over QtWebKit or about a full KDE port?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDEWebKit:
Thinking about a full-fledged port. Sure that's some long term plan I have in mind. Right now is really early, I'm just thinking a bunch of people are going to have to start pioneering and experimenting there. I am an obvious candidate, and I think other QtWebKittens might help too but we'll probably need more people. We'll also need to see what it would mean for rekonq, maybe we can start getting ready, slowly tidying up our code base to see which things we'd reuse, what we'd have to change, the sprint seems like a good time to talk about all this, and maybe start prototyping. On a side note, the INdT guys have a pretty cool web browser, snowshoe, running on top of Qt/WebKit2, check it out it's on github.
On this particular settings topic:
sure, no worries for WebGL, as for frame flattening, I can't really see where it's setting it in your patch, and I'm not really sure it's something we want in rekonq, it's very specific to touch enabled devices IMO. </pre>
<br />
<p>- Pierre</p>
<br />
<p>On October 23rd, 2011, 2:22 p.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2011, 2:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes WebKit Settings window removing the "unuseful" stuffs and adding some news like WebGL or Frame Flattening (probably useful also on netbook).
Let us require QtWebKit 2.2.x, hence Qt 4.8.0 at least until someone will explain me how I can check QtWebKit version number with cmake...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0c52471)</span></li>
<li>src/application.cpp <span style="color: grey">(d770b3d)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(d29a5a3)</span></li>
<li>src/settings/settings_webkit.ui <span style="color: grey">(58fbe45)</span></li>
<li>src/settings/webkitwidget.h <span style="color: grey">(d143510)</span></li>
<li>src/settings/webkitwidget.cpp <span style="color: grey">(04242af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102920/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102920/s/315/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/23/rekonq_webkit_400x100.png" style="border: 1px black solid;" alt="new WebKit settings" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>