[rekonq] Review Request: Add a "Share URL via email" action to rekonq tools

Andrea Diamantini adjam7 at gmail.com
Wed Oct 19 15:56:43 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102674/#review7491
-----------------------------------------------------------


I think adding 3 different actions here is real overkill! Why don't we add just an intelligent "send link..." action that, send page url | attach image url | send link URL depending on the right click position? 

- Andrea Diamantini


On Sept. 26, 2011, 9:52 a.m., Andrea Di Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102674/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2011, 9:52 a.m.)
> 
> 
> Review request for rekonq and Felix Rohrbach.
> 
> 
> Description
> -------
> 
> The bug was requesting a way to share the current URL via email.
> The patch sets up a new action in the rekonq tools to enable sharing the current URL with the default mail application.
> The URL is shared in the body of a new email.
> 
> *NOTE*
> I do not have a KDE git account to commit.
> 
> 
> This addresses bug 226349.
>     /show_bug.cgi?id=226349
> 
> 
> Diffs
> -----
> 
>   src/webview.h 790fa23 
>   src/webview.cpp bd159bd 
> 
> Diff: http://git.reviewboard.kde.org/r/102674/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and working
> 
> 
> Thanks,
> 
> Andrea Di Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111019/06becfd1/attachment-0001.html>


More information about the rekonq mailing list