[rekonq] Review Request: Add the ability to customize the UA string associated to the current host

Andrea Diamantini adjam7 at gmail.com
Wed Oct 19 15:08:19 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102683/#review7489
-----------------------------------------------------------


I don't think we should add this thing. People can really "break" things this way. And please, consider a lot of KDE software using network relies on the UA set in kio.

- Andrea Diamantini


On Sept. 23, 2011, 3:33 p.m., Andrea Di Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102683/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 3:33 p.m.)
> 
> 
> Review request for rekonq, Felix Rohrbach and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> Currently in rekonq the user has the ability to set a pre-defined UA string to the current host by chosing among a fixed set.
> It would be useful for the user to set a specific UA string in case it is not listed in the available ones.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 3144222 
>   src/mainwindow.cpp 528ec21 
>   src/useragent/useragentinfo.h 417aeea 
>   src/useragent/useragentinfo.cpp 8287110 
> 
> Diff: http://git.reviewboard.kde.org/r/102683/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and tested.
> 
> 
> Thanks,
> 
> Andrea Di Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111019/8904028b/attachment.html>


More information about the rekonq mailing list