[rekonq] Review Request: sync feature

Tirtha Chatterjee tirtha.p.chatterjee at gmail.com
Sun Nov 20 12:00:22 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103190/#review8337
-----------------------------------------------------------


I did not go through the entire patch, but I took a brief look at the new classes. It seems that the ftp method is hardcoded in the SyncManager class. How about having an abstract manager from which a FtpSyncManager, WebDavSyncManager, FirefoxSyncManager can derive. What do you think?

I think it would be easier to write the other managers if we derive it from the abstract class.

- Tirtha Chatterjee


On Nov. 20, 2011, 11:28 a.m., Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103190/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2011, 11:28 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> This patch adds the sync feature for rekonq bookmarks, history and passwords. It works (actually) just with remote ftp sites and should be the first stone for other remote sync solutions (webdav? ownCloud? firefox Sync? etc...)
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ced397c 
>   src/application.h acc0335 
>   src/application.cpp fcabc20 
>   src/bookmarks/bookmarkmanager.h PRE-CREATION 
>   src/bookmarks/bookmarkmanager.cpp PRE-CREATION 
>   src/bookmarks/bookmarkowner.cpp 40b070d 
>   src/bookmarks/bookmarkprovider.h fe49eae 
>   src/bookmarks/bookmarkprovider.cpp 9b4be96 
>   src/bookmarks/bookmarkscontextmenu.cpp 735e341 
>   src/bookmarks/bookmarkspanel.cpp eb46119 
>   src/bookmarks/bookmarkstoolbar.cpp 23af65c 
>   src/bookmarks/bookmarkstreemodel.cpp 42cd7b2 
>   src/history/historymanager.h bdce16d 
>   src/history/historymanager.cpp a5cd29e 
>   src/mainwindow.cpp 811f1cf 
>   src/newtabpage.cpp f797e49 
>   src/rekonq.kcfg 227c6b1 
>   src/rekonqui.rc bad5661 
>   src/sync/settings_sync.ui PRE-CREATION 
>   src/sync/syncmanager.h PRE-CREATION 
>   src/sync/syncmanager.cpp PRE-CREATION 
>   src/sync/syncwidget.h PRE-CREATION 
>   src/sync/syncwidget.cpp PRE-CREATION 
>   src/urlbar/bookmarkwidget.cpp 5beecb4 
>   src/urlbar/favoritewidget.cpp da94410 
>   src/urlbar/urlbar.cpp 9460cf8 
>   src/urlbar/urlresolver.cpp e7f41c7 
>   src/webtab.cpp 61c9077 
>   src/webview.cpp bd159bd 
> 
> Diff: http://git.reviewboard.kde.org/r/103190/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Diamantini
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111120/2bc7d359/attachment.html>


More information about the rekonq mailing list